Another stupid issue.

[quadrupleslap]

You see, we had a test today, and sbhstimetable said there was a casual. So we all got excited. And then it turns out that it's just at the last 10 minutes of the class that our normal teacher swaps out for the casual, and we're all sad. Then, I check class variations and it looks like you haven't checked for the type of variation. :frowning:

[fourkbomb]

Pls, do you have the offending entry in today.json/daytimetable.json?

You can look at http://playground.sbhstimetable.tk/try_do_oauth and then http://playground.sbhstimetable.tk/api/today.json?date=2014‒06‒10 to surrender the corresponding entry. Feel free to email it to me if you dislike having to paste it in public for the entire world ;)

On 10 June 2014 17:39, koloktos notifications@github.com wrote:

You see, we had a test today, and sbhstimetable said there was a casual. So we all got excited. And then it turns out that it’s just at the last 10 minutes of the class that our normal teacher swaps out for the casual, and we're all sad. Then, I check class variations and it looks like you haven’t checked for the type of variation. [image: :frowning:]

— Reply to this email directly or view it on GitHub https://github.com/sbhs-forkbombers/sbhs-timetable-node/issues/9.

[quadrupleslap]

Sorry, your "prettified" implementation keeps returning tomorrow's periods, no matter what date I put in. :disappointed:

[fourkbomb]

http://nodejs.sbhstimetable.tk/api/today.json?date=2014‒06‒10 That one works for me.

On 10 June 2014 18:09, koloktos notifications@github.com wrote:

Sorry, your "prettified" implementation keeps returning tomorrow's periods, no matter what date I put in. [image: :disappointed:]

— Reply to this email directly or view it on GitHub https://github.com/sbhs-forkbombers/sbhs-timetable-node/issues/9#issuecomment-45585201 .

[quadrupleslap]

Nope, still telling me tomorrow's lessons. The date parameter has no effect for me.

[gnustomp]

Can confirm date parameter doesn't work.

[fourkbomb]

Meh. http://playground.sbhstimetable.tk/api/daytimetable.json?date=2014-6-10 Does that work?

[gnustomp]

Much better.

On 10 June 2014 19:35, keepcalm444 notifications@github.com wrote:

Meh. http://playground.sbhstimetable.tk/api/daytimetable.json?date=2014-6-10 Does that work?

— Reply to this email directly or view it on GitHub https://github.com/sbhs-forkbombers/sbhs-timetable-node/issues/9#issuecomment-45592931 .

[quadrupleslap]

novariation

[gnustomp]

It'd be better if you give us the relevant bits, if not the whole response, even if you censor things (why would you?). Because we can't test these cases with our own data, we can't be sure it works for everyone.

On 10 June 2014 19:53, koloktos notifications@github.com wrote:

novariation

— Reply to this email directly or view it on GitHub https://github.com/sbhs-forkbombers/sbhs-timetable-node/issues/9#issuecomment-45594443 .

[fourkbomb]

Pls the rest of the variation entry (o_o)

[gnustomp]

ಠ_ಠ show at least the changed, hasCover, casual, casualDisplay, hasCasual, hasVariations, etc.

On 10 June 2014 19:56, keepcalm444 notifications@github.com wrote:

Pls just the variation entry (o_o)

— Reply to this email directly or view it on GitHub https://github.com/sbhs-forkbombers/sbhs-timetable-node/issues/9#issuecomment-45594714 .

[quadrupleslap]

okay, okay =P

{
"period":"1",
"year":"9",
"title":"En5",
"teacher":"HL",
"type":"novariation",
"casual":"HM",
"casualSurname":"Hayman   "
}

{"title":"En5","teacher":"HL","room":"209","year":"9"}