search

sborenst / ansible_aws_deployer

20 stars 20 forks source link

Made a bunch of formatting changes. #34

Closed johannes-cabal closed 7 years ago

johannes-cabal commented 7 years ago

As per best practices, formatting should follow the guidelines below (for readability). Also, added in some todo section, replaced some blocks of shell with modules.

1) Use literal/block formatting Examples: copy: src=/foo/bar/ dest=/foo/bar PROPER copy: src: /foo/bar/ dest: /foor/bar

2) Space before and after variables {{bleh}} vs {{ bleh }}

3) Seperate tags and with_items with_items: [bleh, blah, ha, heh] with_items:

thoraxe commented 7 years ago

Looks like there are merge conflicts. Is that because it needs a rebase?

Did you do any testing of this PR?