scaffold-eth / buidlguidl-v3

https://app.buidlguidl.com/
MIT License
14 stars 18 forks source link

Other pages #99

Closed carletex closed 1 month ago

carletex commented 1 month ago

This PR aims to adapt the style in all the pages (besides homepage :D). I've been talking with Andrea about it, there might be a few tweaks to make, but this could be a good first iteration.

A few notes:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buidlguidl-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 3:32pm
carletex commented 1 month ago

Realized that I missed the build-detail page!

I will work on it tomorrow (in another PR if this gets merged, or here if not :D)

technophile-04 commented 1 month ago

Noiiceeee !!!! Lol didn't expect it ! This is great ! Thanks !!

Some minor things which can we can fix in other PR's :

Tool tips and Models on darkmode : ![Screenshot 2024-05-13 at 10 12 55 PM](https://github.com/scaffold-eth/buidlguidl-v3/assets/80153681/a71930c4-523d-4b31-a6d7-bde1c0053a01) ![Screenshot 2024-05-13 at 10 13 28 PM](https://github.com/scaffold-eth/buidlguidl-v3/assets/80153681/abaaf770-995d-4d3c-b911-37810e308c15)
Nitpick, stuff for `alternativeBaseColor` color : I think there is also discussion on Figma regarding dark mode, lol I think it hard to get the perfect color which matches with gradient (both top and bottom) in dark mode Some suggestions : | Before | After | | ------ | ----- | | ![Screenshot 2024-05-13 at 10 13 43 PM](https://github.com/scaffold-eth/buidlguidl-v3/assets/80153681/6595c669-3ac5-48eb-ab35-7992b681e369) | ![Screenshot 2024-05-13 at 10 27 52 PM](https://github.com/scaffold-eth/buidlguidl-v3/assets/80153681/f782e8f6-fe35-4686-a932-bd7c3f95dc1b) | used `baseColor` in after and added borders, but yeah doesn't look that great with top dark gradient :( Also same for Activity sections ( I think it was mentioned in Figma comment too), but light mode looks great it just with dark mode since gradiend and card colors are kindof from same hue
Stream withdraw table in dark mode, the borders : ![Screenshot 2024-05-13 at 11 08 41 PM](https://github.com/scaffold-eth/buidlguidl-v3/assets/80153681/d54979da-a006-4184-a48b-3c569258f921)
carletex commented 1 month ago

I think there is also discussion on Figma regarding dark mode

Did you learn Spanish? hahaha

Thanks for the suggestions! Regarding the cards, I initially did it with the border + square border (which I like more), but Andrea went for the rounded + no border. But I think it might make sense to have it. Let see what she says and we can tinker in another PRs.

Regarding the other tweaks, maybe we can add them to the issue and complete a bunch of them a single/few PRs