scajanus
commented
4 years ago I did some testing:
- Holdsets are not reset when changing the board year
- problem-results-partial-setup.js can be included in base.html, now it is still getting queried with each click
[18/Mar/2020 11:04:25] "GET /problems?min_grade=5%2B&max_grade=8B%2B&min_overlap=0&set_year=2016&set_angle=40&holdRangeMin=4&holdRangeMax=20&sortedBy=&holdsetsSelected%5B%5D=A&holdsetsSelected%5B%5D=B&holdsetsSelected%5B%5D=school&no-cache=1584529913177 HTTP/1.1" 200 2033 [18/Mar/2020 11:04:20] "GET /static/moonboard/javascript/problem-results-partial-setup.js HTTP/1.1" 304 0
Matter of opinion:
- Holdset selector could be above the board for searching
- & clear button could be below
- clear button doesn't need to clear the 'result' board, just clearing the search board is fine (e.g. in case the user wants to still use the currently shown problem as a basis for the next search, but not the whole thing)
- Have the filters in a separate div apart from the result problems list?
… Needs NUMPY