search

scala-ide / scala-search

Next Scala Search Engine
6 stars 10 forks source link

Stores occurrences of methods in Lucene #19

Closed mads-hartmann closed 11 years ago

mads-hartmann commented 11 years ago

The plugin now keeps an Index (using Lucene) of all the places methods are mentioned in the code-base. A separate Lucene index is created on disk for each project.

The initial indices will be created upon start-up if no index exists already. It will index the entire workspace and traverse the parse-tree of all Scala sources.

For each project in the workspace we create a background job that continuously update the index and re-index files that have changed.

There are two separate tests: OccurrenceCollectorTest contains test that make sure we record the correct information from the parse trees and IndexTest that makes sure the occurrence information can be stored and retrieved from Lucene.

Fix #1001602

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/1/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/1/

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/1/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/1/
sad kitty

mads-hartmann commented 11 years ago

Seems to be a problem with the validator, no the source code :)

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/2/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/2/

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/2/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/2/
sad kitty

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/3/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/3/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/3/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/3/
sad kitty

dotta commented 11 years ago

Seems to be a problem with the validator, no the source code :)

@mads379 I'll check the Jenkins Job used by the validator, but it's good we have it hooked. Thanks @jsuereth!

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/4/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/4/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/4/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/4/
sad kitty

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/5/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/5/

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/5/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/5/
sad kitty

dotta commented 11 years ago

Yes, I admit it, I really had a lot of pleasure in reviewing this PR :) The main reason is that the code is really clean. Trust me, I'd have not been able to go to such deepness if you didn't do a great job in the first place.

I have one more request, would it be possible to add a test for checking correct indexing of constructor declaration and references (both user-defined and synthetic ones).

dotta commented 11 years ago

@mads379 I'm gonna have a look at how to fix the PR validator ;-)

dotta commented 11 years ago

PLS REBUILD ALL

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/6/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/6/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/6/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/6/
sad kitty

dotta commented 11 years ago

PLS REBUILD ALL

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/7/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/7/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/7/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/7/

dotta commented 11 years ago

PLS REBUILD ALL

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/8/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/8/

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/8/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/8/
sad kitty

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/9/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/9/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/9/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/9/

dotta commented 11 years ago

The failure of scala-search-master-2.10-pr-validator Job is correct. To fix it, you need to wide the version range for org.eclipse.jdt.core;bundle-version="[3.6.0,3.7.10)" in your MANIFEST to be org.eclipse.jdt.core;bundle-version="[3.6.0,3.8.10)"

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/10/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/10/

scala-jenkins commented 11 years ago

jenkins job scala-search-3.0.x-2.10-pr-validator: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/10/
sad kitty

scala-jenkins commented 11 years ago

jenkins job scala-search-master-2.10-pr-validator: Success - https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/10/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-master-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-master-2.10-pr-validator/11/

scala-jenkins commented 11 years ago

Started jenkins job scala-search-3.0.x-2.10-pr-validator at https://jenkins.scala-ide.org:8496/jenkins/job/scala-search-3.0.x-2.10-pr-validator/11/