search

scala / scala-jenkins-infra

A Chef cookbook that manages Scala's CI infrastructure.
https://scala-ci.typesafe.com
Apache License 2.0
14 stars 17 forks source link

increase timeout from 150 to 210 minutes #100

Closed SethTisue closed 9 years ago

SethTisue commented 9 years ago

because an attempt at a 2.12.0-M2 release build failed today by running afoul of the old timeout

review/merge by @adriaanm

retronym commented 9 years ago

LGTM

adriaanm commented 9 years ago

I think the real solution is to limit concurrency. There should only be one release job running at a time. No need to increase timeout for all jobs. We want to detect when they start taking longer. Note that the build passed without this change (merging doesn't actually deploy the change).

SethTisue commented 9 years ago

(the build took 160 minutes — it only passed because I also manually increased the timeout in the Jenkins UI)

adriaanm commented 9 years ago

good call! :rabbit:

SethTisue commented 9 years ago

also, it's possible that the increased time in this case had to do with concurrency, but it might also just be that the M2 compiler is slow. Jon Pretty is reporting "23% slower" than 2.11

adriaanm commented 9 years ago

yep, we should increase, but only just enough so that we discover further slow downs -- Lukas & Jason are going to focus on optimizing the optimizer, so I don't expect this to be a problem :)

adriaanm commented 9 years ago

In any case, we shouldn't increase the timeout for 2.11.x

SethTisue commented 9 years ago

agree. see new ticket