search

scala / scala-jenkins-infra

A Chef cookbook that manages Scala's CI infrastructure.
https://scala-ci.typesafe.com
Apache License 2.0
14 stars 17 forks source link

Add STARR_REF param to bootstrap job #166

Closed retronym closed 8 years ago

retronym commented 8 years ago

The new parameter was added to the boostrap script in:

https://github.com/scala/scala/pull/4976

I have manually added this parameter via the Jenkins UI in the meantime.

retronym commented 8 years ago

Review by @adriaanm

Testing this out https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-bootstrap/326/console

retronym commented 8 years ago

@adriaanm @SethTisue @szeiger

I'd like to be able to use the product of this build as STARR for a PR against scala/scala. Would appreciate your thoughts on this. Here are mine:

We'll need to convince scripts/jobs/validate/publish-core to use https://scala-ci.typesafe.com/artifactory/scala-release-temp/. I am doing this locally with the file ~/.sbt/repositories containing:

[repositories]
  local
  typesafe-ivy-releases: http://repo.typesafe.com/typesafe/ivy-releases/, [organization]/[module]/[revision]/[type]s/[artifact](-[classifier]).[ext], bootOnly
  maven-central
  sonatype-snapshots: https://oss.sonatype.org/content/repositories/snapshots
  private-repo: https://scala-ci.typesafe.com/artifactory/scala-release-temp/

I could modify publish-core in my pull request to write out that file. Looks like we already have per-job isolation of $SBT_HOME (it is set to SBT_HOME="$WORKSPACE/.sbt"), so it should be safe to drop this file in there.

Alternatively, I could pass the SCALA_VER_BASE parameter to the bootstrap job (or even tag the commit) to send the binaries to Sonatype. I'd rather not do this in the first instance, as I'm sure there will still be some iteration required.

retronym commented 8 years ago

I could modify publish-core in my pull request to write out that file

Here's my attempt at that: https://github.com/retronym/scala/commit/b76bcafd71c38f116d47bfc15eeac5e0ba1ca3b3

retronym commented 8 years ago

Getting closer, trying again with a fix for the broken JUnit test in the backend: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-bootstrap/327/console

Works!

SethTisue commented 8 years ago

ping me about this next week if you still need feedback? unless it's actually pretty urgent? in the meantime, I deployed your change