scala / scala-jenkins-infra

A Chef cookbook that manages Scala's CI infrastructure.
https://scala-ci.typesafe.com
Apache License 2.0
14 stars 17 forks source link

Make jvmSelect function JDK 9 aware #221

Closed retronym closed 7 years ago

retronym commented 7 years ago

See: http://openjdk.java.net/jeps/223

We could simplify the logic by changing the callers of this script (Jenkins job parameters) from "jvmSelect oracle 8" to "jvmSelect oracle 1.8"

But for now I've retained compatibility with assuming the leading "1."

retronym commented 7 years ago

Tested on the worker:

$ source /tmp/jvm-select.sh
/usr/lib/jvm/java-8-openjdk-amd64/bin/java

$ (jvmSelect oracle 9; javac -version)
Java home: /usr/lib/jvm/jdk-9-ea-oracle
javac 9-ea

$ (jvmSelect openjdk 8; javac -version)
Java home: /usr/lib/jvm/java-1.8.0-openjdk-amd64
javac 1.8.0_111

$ (jvmSelect oracle 6; javac -version)
Java home: /usr/lib/jvm/java-6-oracle-amd64
javac 1.6.0_45
retronym commented 7 years ago

Note that I've already manually pushed this onto jenkins-behemoth-{1,2}