search

scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

Citations #113

Closed ckarpinski closed 1 year ago

ckarpinski commented 1 year ago

Story

We wanted our citation tool to be like we have it in the digital library. To do this I grabbed all the related citation files from the PALS project and added them to ours. I adjusted Citations to say Cite this item and added some CSS to style them.

I added to the rubocop file to match what PALS had as well - not sure if this was needed or not.

Running rubocop showed 3 issues "Rails/OutputSafety: Tagging a string as html safe may be a security risk. text.html_safe" but since this is the same code that is in PALS I think it must be okay.

Refs #issuenumber

Expected Behavior Before Changes

Expected Behavior After Changes

Screenshots / Video

Notes

summer-cook commented 1 year ago

Its odd that the linting is still failing even when you added those files to the rubocop_todo.yml. Can you disable/enable rubocop around the lines of code that are throwing those errors?

Details on how to do that: https://stackoverflow.com/questions/67425427/rubocop-how-to-disable-enable-cops-on-blocks-of-code