search

scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

121-embargo-auto-expire #166

Closed alishaevn closed 1 month ago

alishaevn commented 9 months ago

Story

WIP: this doesn't work as of yet.

This code is copied from https://github.com/samvera/hyrax/pull/6241 to solve https://github.com/scientist-softserv/atla-hyku/issues/121. In that PR, the ability to expire embargoes using a rake task works.

The copied code has not been included in a release yet. At the time of this writing, September 26, 2023, it is in hyrax main. The latest release is hyrax-v4.0.0.

This app is currently using hyrax-v3.5.0. However, since the changes being brought in are coming from hyrax main, I'm including the entire files instead of writing decorators.

Expected Behavior Before Changes

Expected Behavior After Changes

Screenshots / Video

Notes

alishaevn commented 9 months ago

the error I'm getting can be seen in the screenshot below. it occurs with these code changes from hyrax main (first commit in this pr), and without them. (the same error occurs, I didn't actually do the step through with the changes to see if the error comes from the same place, but I feel like it does)

screenshots Screenshot 2023-09-26 at 3 58 48 PM image