scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

Introduces importer permission restrictions #193

Closed laritakr closed 7 months ago

laritakr commented 7 months ago

Story

Introduces an Advanced Depositors group with Work Importer role. Addresses previously failing ability specs.

Refs

Expected Behavior Before Changes

Importers and exporters are open to everyone

Expected Behavior After Changes

Only Admin user and those in the Advanced Depositor group will have access to importers and exporters

Screenshots / Video

Screenshots ### default user with no added permissions ![Screenshot 2023-11-22 at 1 58 08 PM](https://github.com/scientist-softserv/atla-hyku/assets/17851674/09350e8f-4efd-4e5f-b338-a25c0fa7d9ab) ### when default user tries /importers route ![Screenshot 2023-11-22 at 1 58 45 PM](https://github.com/scientist-softserv/atla-hyku/assets/17851674/90667c06-603e-46a2-acfc-9fa564396e70) ### user in Advanced Depositors group ![Screenshot 2023-11-22 at 1 59 21 PM](https://github.com/scientist-softserv/atla-hyku/assets/17851674/59fd06c4-ad78-46ad-b619-4e4c8fa41f1a) ### Admin user ![Screenshot 2023-11-22 at 2 00 16 PM](https://github.com/scientist-softserv/atla-hyku/assets/17851674/4066af86-b38d-4bd3-b6e9-19953f4a763b) ### New group and role ![Screenshot 2023-11-22 at 2 00 33 PM](https://github.com/scientist-softserv/atla-hyku/assets/17851674/b2f8cd92-1da8-4970-99a6-fa1fb9aa4175)

Notes

laritakr commented 7 months ago

I think this makes sense, though I'm curious if they access the importers can't they also import Collections and FileSets as well? Or is it only works?

Yes I'd assume that they can import anything since this just gives access to Bulkrax. I just mimicked the "work depositor" role when I made the "advanced depositor" role for Bulkrax for consistent terminology.