scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

🐛 Fix "Add to Collection" for page 2+ of works #198

Closed laritakr closed 7 months ago

laritakr commented 7 months ago

Story

Prior to this commit, when you were on page 2 of your works and selected a work to add to a collection, the query for available collections would use the page 2 as part of the collection query. This would mean the first 100 collections (default page size) that you had access to add works to were skipped.

With this commit, we omit the query parameters from the works page and then query collections.

Refs #194

Expected Behavior Before Changes

When selecting works from page 1 and using Add to Collection, user was able to select a collection. For subsequent pages of works, no collection was found.

Expected Behavior After Changes

Add to Collection button works on all pages of works.

Screenshots / Video

![Screenshot 2023-11-27 at 3 21 28 PM](https://github.com/scientist-softserv/atla-hyku/assets/17851674/c68d6915-343d-4146-a5d3-420f383170e9) ![Screenshot 2023-11-27 at 3 23 22 PM](https://github.com/scientist-softserv/atla-hyku/assets/17851674/ba44e077-c89a-4e44-8162-31c5e7ee5011) ![Screenshot 2023-11-27 at 3 23 29 PM](https://github.com/scientist-softserv/atla-hyku/assets/17851674/d53f8bc3-99f0-4139-ac88-d0281af0184c)

Notes