scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

Generic worktype #22

Open summer-cook opened 1 year ago

summer-cook commented 1 year ago

Story

As a user I can create a Generic Work Type customized to this spreadsheet

Expected Behavior Before Changes

A basic Generic Work model is available.

Expected Behavior After Changes

The Generic Work Type Customizations:

Ref Issues Inlcuded:

Screenshots / Video

Video creating and then editing a Generic Work: https://share.getcloudapp.com/04u6wOYQ

CLICK FOR SCREENSHOTS Screenshot 2023-05-03 at 16 20 55 Screenshot 2023-05-03 at 22 50 22 Screenshot 2023-05-03 at 22 49 39 Screenshot 2023-05-03 at 22 49 18 Screenshot 2023-05-03 at 16 21 12

Notes

N/A

QA Testing Checklist:

Generic Work Type:

REQ FIELDS DISPLAYED: On the form, I can see the required fields:

REQ'D FIELDS LABELED/DISPLAYED:

FORM LABELS:

HELP TEXT:

MULTIPLE FIELDS:

CONTROLLED VOCABULARY: On the form, I can see the correct controlled vocab show for the following fields:

ADDITIONAL METADATA DISPLAYED: After clicking the “Additional Fields” button I can see the non-required fields for the GenericWork model:

EDITING A WORK: When I click edit on a work:

THE SEACRH RESULTS PAGE: On the search results page you will see the following properties displayed on each work listed in the results.

THE FACETS THAT SHOULD DISPLAY: On the facets, after creating a generic work with all the form fields filled in. You navigate to the search results page and can see the following facets included:

Please double check the accuracy of the form fields' help text by cross checking from in column G titled "Help Text" of this spreadsheet to the Generic Work form fields we updated listed below:

Please also check to make sure when you flip through the different languages of those help texts' that the help text appears to change to the alternate language selected for the fields listed above.

OLD in drop down labelled CLICK ME

CLICK ME # Summary Set up the atla hyku generic worktype This is the mapping spreadsheet. https://docs.google.com/spreadsheets/d/1cyTtAofi2g1sx0ATJuP7ws-77a7OzBXF/edit#gid=1372594593 # Related #7 epic # Acceptance Criteria - [ ] metadata fields from the spreadsheet for generic worktype are available - [ ] Require fields for generic worktype are correct per the spreadsheet - [ ] Multi value fields for generic worktype are correct per the spreadsheet - [ ] Help text (text below name but above the field) is correct for generic worktype # Notes most likely one dev will work on all 3 worktypes Samvera customizing metadata guide: [link](https://samvera.github.io/customize-metadata-generate-work-type.html)
DiemBTran commented 1 year ago

QA notes:

DiemBTran commented 1 year ago

Needs further review: It's almost all there! Just missing 2 fields. See attached screenshots.

tested on:

needs rework:

click to expand ![title Generic Work db5e7a1c-4ffc-46f4-a28d-5514e6df2175 Hyku 2023-05-11 at 5 41 56 PM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/7a29aa15-cb3b-4c6d-800e-2103f1b8a70a) ![Generic Work title ID db5e7a1c-4ffc-46f4-a28d-5514e6df2175 Hyku 2023-05-11 at 5 38 09 PM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/0cb1ad07-0c16-4e09-963b-01526261161c)
summer-cook commented 1 year ago

Rework

Additional Rights info: Image

Bibliographic Citation:

Image

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screenshot.

tested on:

now passing:

Additional Right Info and Bibliographic Citation are now correct on Generic Work ![Generic Work generic work additional rights info and bibliographic citation ID a95af658-d213-4f87-b0e3-29f7a8b62b81 Hyku 2023-05-12 at 5 26 47 PM (1)](https://github.com/scientist-softserv/atla-hyku/assets/29311858/f67e45a9-b186-46c2-a11a-64f06a443470)
ckarpinski commented 1 year ago
summer-cook commented 1 year ago

@ckarpinski these are all addressed on other tickets, besides this one:

Looking at PALS, it seems they do not have "GENERIC WORK" showing on the work show page, is this a theme adjustment for me to do later or can it be done in some settings?

In the default show page theme, it does show Generic Work (excuse the ugly theming on their qa tenant) Image

Can you send me the link for where this is not the case?

It may just be that they have a theme applied to that tenants show page (you would do this in Settings -> Appearance -> Themes)

summer-cook commented 1 year ago

Confirmed - with the "Cultural Show" page theme, it does not show the worktype at the top. Not sure about "Scholarly Show" theme, but you can try it if you'd like ・ᴗ・

Image

ckarpinski commented 1 year ago

The test work i made on hyku commons for some reason says pending and i cant figure out how to change that - it is public and otherwise looks like other works. I have our test site there set to use "Default Show Page" not Cultural Show and it does not show the work type.

https://atla.hykucommons.org/concern/generic_works/3d1ef7a3-8305-4d2c-baa8-c5027b6f52ec?locale=en

ckarpinski commented 1 year ago

What ticket has the help text for subject and language on it?

summer-cook commented 1 year ago

What ticket has the help text for subject and language on it?

i fixed them as part of the etd ticket.