scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

Normalize Subject Field #28

Open summer-cook opened 1 year ago

summer-cook commented 1 year ago

Summary

Subject will not be a controlled vocabulary except that it will be normalized to include special capitalization. see info here: https://docs.google.com/spreadsheets/d/1cyTtAofi2g1sx0ATJuP7ws-77a7OzBXF/edit#gid=785133840

For subject add logic to force first letter capitalization. Strip out trailing periods and trailing spaces (like DL has)

Related

EPIC: #8

Testing Instructions

Create a work for each worktype.

Generic

ETD

Paper or Report

Notes

DiemBTran commented 1 year ago

Needs further review: Generic Work's subject field passes, but not ETD. Was not tested on on Paper or Report because this work type doesn't have subject.

tested on:

Generic Work's subject field normalized correctly, but not ETD ![subject field - generic work Generic Work b78f2184-689b-4e41-97fb-99645e7c5aba Hyku 2023-05-12 at 11 54 53 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/a4101534-b442-468d-b6bc-7fad080a1ce0) ![Generic Work subject field - generic work ID b78f2184-689b-4e41-97fb-99645e7c5aba Hyku 2023-05-12 at 11 56 00 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/f39693ee-6923-4b27-aab5-ddd1cc354d80) ![subject field - etd Etd 95d30b0b-277f-4016-9c44-6dc7846d487b Hyku 2023-05-12 at 11 55 17 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/17d6154c-276e-4e7c-9bdf-950cb02a2a18) ![Etd subject field - etd ID 95d30b0b-277f-4016-9c44-6dc7846d487b Hyku 2023-05-12 at 11 56 14 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/dbc2853a-e8b0-4bef-ba12-92d1e6dcdd26)