scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

Controlled Vocabularies - Date #29

Open summer-cook opened 1 year ago

summer-cook commented 1 year ago

Summary

These are the controlled vocabularies needed for ATLA: https://docs.google.com/spreadsheets/d/1cyTtAofi2g1sx0ATJuP7ws-77a7OzBXF/edit#gid=785133840

Related

EPIC: #8

Acceptance Criteria

Testing Instructions

ETD

Notes

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screenshots.

tested on:

ETD's date has a dropdown menu for the year. Generic Work and Paper or Report have text fields for the whole date. ![Etd Hyku 2023-05-12 at 12 52 21 PM (1)](https://github.com/scientist-softserv/atla-hyku/assets/29311858/c0c6fadb-642a-416f-9561-5bd004a5a355) ![Etd controlled vocab - date - etd ID 1ed7f21a-589f-4431-9644-244cbeec6bd9 Hyku 2023-05-12 at 12 54 45 PM (1)](https://github.com/scientist-softserv/atla-hyku/assets/29311858/313bc895-d568-4172-82ba-42f072389d6f) ![controlled vocab - date - generic work Generic Work 17b02c21-9391-45b8-8193-80835478969b Hyku 2023-05-12 at 12 53 56 PM (1)](https://github.com/scientist-softserv/atla-hyku/assets/29311858/45d36689-2696-45a3-86e5-11f8154ae3af) ![Generic Work controlled vocab - date - generic work ID 17b02c21-9391-45b8-8193-80835478969b Hyku 2023-05-12 at 12 54 30 PM (1)](https://github.com/scientist-softserv/atla-hyku/assets/29311858/1c3ad28d-19e7-43f2-a8e7-374eea75af45) ![controlled vocab - date - paper or report Paper Or Report ddb95804-1d75-48e5-806f-ef4b09603d65 Hyku 2023-05-12 at 12 54 09 PM (1)](https://github.com/scientist-softserv/atla-hyku/assets/29311858/ae841db1-7d7e-4309-8486-4d674f6574f9) ![Paper Or Report controlled vocab - date - paper or report ID ddb95804-1d75-48e5-806f-ef4b09603d65 Hyku 2023-05-12 at 12 54 38 PM (1)](https://github.com/scientist-softserv/atla-hyku/assets/29311858/7154678d-b2ed-4e25-9b0a-073e041657c7)
ckarpinski commented 1 year ago

I did not realize this was goign to be a dropdown list. I had imagined you type a year freely but it only allows it within that range.

I checked in with Christine about this - we dont want a dropdown list. It really needs to be something you can freely type in a year. Ideally it would be compared to a list of years and only allow proper years, but maybe at worst it only allows 4 numbers in that field? a steup up from that - it only allows 4 numbers and has to start with 19 or 20?

summer-cook commented 1 year ago

Options

summer-cook commented 1 year ago

Just made this change - year on ETD should now be a 4 digit field that accepts 4 numbers, beginning with 19 or 20

summer-cook commented 1 year ago

Softserv QA:

Year validation is added and field is updated

Image