Closed summer-cook closed 1 year ago
@labradford
My comments are just suggestions, I think it's ok to approve. I do think the conditional rendering of the UV/Video/Representative media is a bit convoluted.
Great job remembering the themes!
I know, originally i wanted to just put it in the representative_media
partial and be done with it, but then that ALSO required changes to the show page since there are viewer related conditionals in there too. I will test out your suggestions though, thank you!
@labradford i just pushed up the show page views again with your suggestions, but had to do some weird things with the default one to get the columns to work. let me know if you want to take a look again
Story
SoftServ will customize the ability for YouTube videos to appear embedded on a work show page. Videos will not be played back in Universal Viewer.
Related
9
Expected Behavior Before Changes
Expected Behavior After Changes
video_embed
link saved in its metadata, the work show page will show that video in an iframe.video_embed
link saved in its metadata, but should show the universal viewer because it has files, it shows the viewer.video_embed
metadata or files to show in the viewer, it shows the default image.Screenshots / Video
Working youtube player
Working vimeo player
Form with error message for invalid url entry
Acceptance
Note