scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

Importer: `source identifier` getting parsed as `source` #61

Open DiemBTran opened 1 year ago

DiemBTran commented 1 year ago

Story

While testing #26 for importers, I found that all 3 work types' source identifiers are getting parsed as source. This is even true for paper or report, which is not supposed to have source at all according to Work Types Metadata - SoftServ

Acceptance Criteria

Screenshots / Video

Source Identifiers are being parsed as Source ![ATLA Hyku CSV for Importers - ETD 2023-05-12 at 6 20 23 PM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/7041b659-624d-41dd-805e-3f78859a06eb) ![Show Entry Hyku 2023-05-12 at 6 21 19 PM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/0e10174f-d758-444a-b0e8-a8ef588eb426) ![ATLA Hyku CSV for Importers - GenericWork 2023-05-12 at 6 34 12 PM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/eb0d4596-e798-47f6-9032-be9b9cbda75e) ![ATLA Hyku CSV for Importers - GenericWork 2023-05-12 at 6 34 35 PM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/3102e85c-8465-4f53-8af7-830e91072475) ![ATLA Hyku CSV for Importers - PaperOrReport 2023-05-12 at 6 43 46 PM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/af8d16b8-b9b6-4c25-a563-ac62ecaa7c42) ![Work Types Metadata - SoftServ xlsx - Google Sheets 2023-05-12 at 6 45 31 PM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/213382b3-9306-4eae-8712-3f26e87d184a)

Testing Instructions and Sample Files

Notes

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screenshots.

tested on:

"source identifier" is no longer being parsed to "source" ![Show Entry Hyku 2023-05-16 at 11 53 12 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/281b2d67-6b36-4222-9846-e317132073b7) ![Etd ETD Title ID 1fb23902-8378-43a9-b325-70f5b996ca61 Hyku 2023-05-16 at 11 53 34 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/156f2c6f-f18c-4ca0-a152-e38691b4c2cd) ![Show Entry Hyku 2023-05-16 at 11 53 58 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/44b53b28-eaa4-4586-a7be-bf6b36c20486) ![Paper Or Report Paper or Report TITLE ID 99f34de7-d406-4525-9020-43af3bee9160 Hyku 2023-05-16 at 11 54 12 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/1f7465f2-2b99-484c-b28e-dafdd2c6589a) ![Show Entry Hyku 2023-05-16 at 11 54 24 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/a59ef77d-316d-4315-ae66-bc1187497dad) ![Generic Work GW TITLE ID 2edd608b-4d42-40a9-9e15-bab9e5ceeef1 Hyku 2023-05-16 at 11 54 42 AM](https://github.com/scientist-softserv/atla-hyku/assets/29311858/b4729ae1-4316-4fcf-9500-bed76cb807af)