scientist-softserv / atla-hyku

Other
0 stars 0 forks source link

Video that is vertical is getting stretched to be horizontal #68

Open ckarpinski opened 1 year ago

ckarpinski commented 1 year ago

I uploaded a video that was recorded vertical instead of horizontal. It does not keep the correct aspect ratio - it is stretched out into a horizontal view.

https://christy.atla-hyku.notch8.cloud/concern/generic_works/d8df12ac-e84d-4cfd-9534-90b35044c766

summer-cook commented 1 year ago

notes:

summer-cook commented 1 year ago

@ckarpinski This is a known bug in hyrax that affects solely iPhone videos. I checked with @kirkkwang who worked on British libraries, and they saw the same problem in their staging. You can see this comment on their repo for more information about why this happens. https://github.com/scientist-softserv/britishlibrary/issues/214#issuecomment-1438844001

Unless you foresee many works having iPhone videos attached, this should hopefully not come up too much. The good news is that other vertical videos - anything not created with an iphone, will show up with the correct orientation. Here is an example of one i just created on staging

Since fixing this would require refactoring core hyrax functionality, this ticket would not be in scope for this project. But I will leave it open (in no status) in case it is something that you want to prioritize in the future