Closed gagnonanthony closed 2 months ago
I abide toward a more open 755 set of permissions on the files, but are open to change, if anyone has good reasons. I'm not super good with this kind of thing, so maybe 755 poses a security risk ? I don't think so, but I'm not sure.
755 - owner can read/write/execute, group/others can read/execute
644 - owner can read/write, group/others can read only
From here
Not sure how those permissions were changed 🤔. Due to my limited knowledge on this matter, I have no preference at all! Happy to change it back to 755 if needed.
Yes, revert for now. I'll add a to-do to research this a bit further.
Just to be safe, do you want me to set all files to 755? Or only those that were changed? I tried doing a chmod -R 755 modules/nf-scil/denoising/
and most files got changed. Just wanna be sure 😆 (I got scared of committing that)
Just fix yours 😅 But now that I know, I'll urge this a bit more
Type of improvement
If submitting a new module or fixing a bug, please use the appropriate template.
Describe your improvement
Migrate nlmeans and mppca modules to scilpy 2.0.0 + nf-test.
Checklist before requesting a review
79 #114