search

scottbot95 / RoR2ModManager

A simple mod manager built using electron. Currently only supports BepInEx mods
MIT License
25 stars 3 forks source link

[BUG] Mod filter does not match spaces #107

Closed krissrex closed 5 years ago

krissrex commented 5 years ago

Describe the bug Filtering mods (searching) will not match if the filter has spaces in it.

To Reproduce Steps to reproduce the behavior:

  1. Go to Select packages
  2. Type in Ro R2 in Filter textbox
  3. No matches for R2 Ro Mod Manager is shown

Expected behavior The results should include at least Ro R2 Mod Manager and other results with spaces in their names.

Screenshots image

Desktop (please complete the following information):

krissrex commented 5 years ago

I think the reason is that package-table-datasource.ts is not searching in the humanized version of the package table.

scottbot95 commented 5 years ago

Yeah that's almost certainly the issue. I'm out of town until the 8th. I can take a crack at it then.