Closed scottlamb closed 2 years ago
Right now the loss_since_mark fields in aac.rs talk about how they're important for determining if a fragment is complete or not:
loss_since_mark
aac.rs
https://github.com/scottlamb/retina/blob/0178e7fbc20453fdb49894aa669f9af089285a45/src/codec/aac.rs#L437-L441
...but they're not actually used or passed on in the AudioFrame. That's suspect. But there are no tests, and I want to add tests before messing with the logic to know I'm making things better, not worse.
AudioFrame
Right now the
loss_since_markfields inaac.rstalk about how they're important for determining if a fragment is complete or not:https://github.com/scottlamb/retina/blob/0178e7fbc20453fdb49894aa669f9af089285a45/src/codec/aac.rs#L437-L441
...but they're not actually used or passed on in the
AudioFrame. That's suspect. But there are no tests, and I want to add tests before messing with the logic to know I'm making things better, not worse.