search

scottlamb / retina

High-level RTSP multimedia streaming library, in Rust
https://crates.io/crates/retina
Apache License 2.0
218 stars 46 forks source link

Ignore UDP connection refused errors #86

Closed spencercw closed 11 months ago

spencercw commented 11 months ago

The packets sent by punch_firewall_hole can elicit a 'destination unreachable' ICMP response from the server, which gets turned into a 'connection refused' error. This is not actually a problem so just ignore them.

spencercw commented 11 months ago

Yeah it's not really obvious how to test this. As you say, mocking out the interface is probably more effort than it's worth for this change.

spencercw commented 11 months ago

The clippy errors are fixed in the other PR.

spencercw commented 11 months ago

Rebased on main.

scottlamb commented 11 months ago

All merged. Would you like a release with these changes?

spencercw commented 11 months ago

Thanks but I've got another change I'm waiting on, so I'm just going to have to stick with my fork for now.