search

scpeters-test / sdformat

Simulation Description Format (SDF) parser and description files.
http://sdformat.org
Other
1 stars 0 forks source link

Please use the newer tinyxml2 instead of tinyxml #209

Open scpeters-test opened 5 years ago

scpeters-test commented 5 years ago

Original report (archived issue) by yurivict (Bitbucket: yurivict).

I had to apply this patch:

-  pkg_check_modules(tinyxml tinyxml)
+  pkg_check_modules(tinyxml tinyxml2)
   if (NOT tinyxml_FOUND)
-    find_path (tinyxml_include_dirs tinyxml.h ${tinyxml_include_dirs} ENV CPATH)
-    find_library(tinyxml_LIBRARIES NAMES tinyxml)
+    find_path (tinyxml_include_dirs tinyxml2.h ${tinyxml_include_dirs} ENV CPATH)
+    find_library(tinyxml_LIBRARIES NAMES tinyxml2)
     set (tinyxml_FAIL False)
     if (NOT tinyxml_include_dirs)
-      message (STATUS "Looking for tinyxml headers - not found")
+      message (STATUS "Looking for tinyxml2 headers - not found")
       set (tinyxml_FAIL True)
     endif()

tinyxml doesn't install .pc files and isn't found, but tinyxml2 is easily found.

scpeters-test commented 5 years ago

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).