Allow receiving an external tree, drop python 3.7

scrapinghub / extruct

Extract embedded metadata from HTML markup

BSD 3-Clause "New" or "Revised" License

846 stars 113 forks source link

Closed croqaz closed 1 year ago

croqaz commented 1 year ago

A small performance improvement: allow receiving an external tree into extruct. Also bump the default Python version to 3.9, hope that's OK.

lopuhin commented 1 year ago

@croqaz thanks for the PR! Do you mind updating supported versions in https://github.com/scrapinghub/extruct/blob/9453e4348e06509e7716ada3de585cddfe2ad0d4/setup.py#L67 -- and also having a look at the CI, it seems we also run 3.7 and 3.11 on this branch (and then we don't need to drop 3.7 I guess, although I would not mind at all).

croqaz commented 1 year ago

According to https://devguide.python.org/versions/ at this point in time, 3.7 is dead, and 3.8 has a bit over a year. Looks safe to remove 3.7.

lopuhin commented 1 year ago

Sounds great! Do you mind also mentioning this feature in the README? We don't build docs here so it would be useful to mention it there.

croqaz commented 1 year ago

Thank you for the review Konstantin!