search

scrapy / scrapely

A pure-python HTML screen-scraping library
1.86k stars 315 forks source link

Improved price extraction #103

Closed hackrush01 closed 7 years ago

hackrush01 commented 7 years ago

The prices are now handled using regexp, strings and loops instead of only regex which was inaccurate in some cases.

Fixes https://github.com/scrapinghub/portia/issues/212

hackrush01 commented 7 years ago

@ruairif Completed the changes, please review. https://github.com/scrapy/scrapely/pull/103/files

hackrush01 commented 7 years ago

@ruairif Yes, the extra part in regex was indeed not required. Fixed. Please check.

hackrush01 commented 7 years ago

@ruairif I have made the required changes, please check. https://github.com/scrapy/scrapely/pull/103/files