search

scrapy / scrapely

A pure-python HTML screen-scraping library
1.86k stars 272 forks source link

Fix typo in docstrings, remove unused imports, fix PEP indents. Update Travis configuration. #107

Closed AmbientLighter closed 6 years ago

ruairif commented 6 years ago

@AmbientLighter Can you try replacing pypy in the .travis.yml file with: pypy-5.7.1 and change the python version at the top of the file to 3.6 to see if that fixes the tests.

lopuhin commented 6 years ago

Hi @ruairif I think scrapy should have an up to date version of pypy in .travis.yaml: https://github.com/scrapy/scrapy/blob/f729d74886be2290fcbbcaa21d366b770ff21008/.travis.yml#L26-L38

AmbientLighter commented 6 years ago

Hm, it looks like NumPy isn't compatible with recent releases of PyPy. Shall we ignore these errors, downgrade PyPy or drop PyPy from test matrix?

ERROR: Failure: ImportError ( Importing the multiarray numpy extension module failed. Most likely you are trying to import a failed build of numpy. If you're working with a numpy git repo, try git clean -xdf (removes all files not under version control). Otherwise reinstall numpy. Original error was: unable to load extension module '/home/travis/build/scrapy/scrapely/.tox/pypy/site-packages/numpy/core/multiarray.pypy-41.so': /home/travis/build/scrapy/scrapely/.tox/pypy/site-packages/numpy/core/multiarray.pypy-41.so: undefined symbol: Py_EnterRecursiveCall

ruairif commented 6 years ago

@AmbientLighter While the tests say they ran correctly they actually failed to run. Can you try the method that @lopuhin suggested above instead?

lopuhin commented 6 years ago

@ruairif I think @AmbientLighter already tried it and there was a problem with importing numpy (not sure what is the reason, as recent pypy should be able to build and import numpy). But looking through the builds, I see one pypy build that succeeded: https://travis-ci.org/scrapy/scrapely/builds/289894834 (the last one, https://travis-ci.org/scrapy/scrapely/jobs/289894842)

ruairif commented 6 years ago

@lopuhin That's interesting from the job you linked it looks like it uses pypy2.7 regardless of the toxenv chosen is you use the pypy image version. @AmbientLighter Can you try with just:

python:
- py3.6
- pypy

env:
- TOXENV=py2.7
- TOXENV=py3.6
AmbientLighter commented 6 years ago

@ruairif @lopuhin Thank you for the suggestions, all tests have been executed successfully by Travis, and this MR is ready for the review.