search

scratchfoundation / scratch-paint

Paint editor for Scratch 3.0
https://llk.github.io/scratch-paint/
BSD 3-Clause "New" or "Revised" License
175 stars 229 forks source link

The react-popover library, used in the color sliders, is unmaintained #1122

Open adroitwhiz opened 4 years ago

adroitwhiz commented 4 years ago

Expected Behavior

We should use libraries that still receive updates

Actual Behavior

react-popover, used for the color slider popover, was last updated 2 years ago.

It contains a bug where it recognizes mouse and touch events but ignores pointer events, which is blocking https://github.com/LLK/paper.js/pull/37. I was hoping to get a fix merged into it, but they don't seem to be looking at any pull requests.

Jacco commented 4 years ago

This one seems to have about the same functionality and is still maintained:

https://www.npmjs.com/package/react-tiny-popover

You could also consider rolling a self-made version to have one less dependancy.

adroitwhiz commented 4 years ago

I looked into react-tiny-popover but it uses createRef which isn't supported in the old version of React that Scratch currently uses.

Jacco commented 4 years ago

Yikes ok, version 16 is used right?

adroitwhiz commented 4 years ago

Yes, but there are a variety of point-releases that add new features and deprecate (but don't break) old ones.

Jacco commented 4 years ago

popperjs

As far as I can see you have to do a bit of work yourself but seems good.

Jacco commented 4 years ago

Ah also 16.8.0

fsih commented 4 years ago

We should look at updating our React version