search

scratchfoundation / scratch-paint

Paint editor for Scratch 3.0
https://llk.github.io/scratch-paint/
BSD 3-Clause "New" or "Revised" License
175 stars 230 forks source link

Should user-created groups be preserved? #513

Open fsih opened 6 years ago

fsih commented 6 years ago

Expected Behavior

In the vector paint editor If the user selects everything on the canvas and groups it, then changes costumes and changes back, should the group be preserved?

Actual Behavior

The top level group will be ungrouped

chexbox commented 6 years ago

Shouldn't all groups be preserved?

fsih commented 6 years ago

@chexbox We are ungrouping the top-level group so that characters are poseable in the paint editor. Grouping is difficult for beginners to understand, and ungrouping is the first thing you have to do to most sprites in order to move their arms or legs. (We're also trying to make the new sprites we add more poseable)

apple502j commented 5 years ago

@fsih There are some voices from community like https://scratch.mit.edu/discuss/topic/369401/ Maybe you can try adding a comment on SVG file like <!-- PAINT: preserve group -->. I'm sure comments won't affect parsing.

Should I prototype?

fsih commented 5 years ago

Paper.js is already adding attributes that aren't in the SVG spec to our groups, such as , we could add our own attribute, such as scratch-group="true"

If you would like to prototype, go for it, thanks!