scratchfoundation / scratch-paint

Paint editor for Scratch 3.0
https://llk.github.io/scratch-paint/
BSD 3-Clause "New" or "Revised" License
175 stars 230 forks source link

Paint editor bug - Gradients persist in solid fill mode #783

Open thisandagain opened 5 years ago

thisandagain commented 5 years ago

Notice how the fill swatch does not contain a gradient, but the fill preview does. Fill preview should match the swatch.

image

To repro:

  1. Select the paint bucket tool
  2. Change the fill mode to gradient
  3. Change the 1st gradient color to any color
  4. Change the 2nd gradient color to "no fill"
  5. Change the fill mode to solid
  6. See what happens when you paint bucket that color onto anything

(It's possible that this only happens when eye-dropper-ing in solid fill mode.)

My specs: Google Chrome Version 70.0.3538.102 (Official Build) (64-bit) MacOS High Sierra Version 10.13.14


Moved from LLK/scratch-gui#3970 /cc @kathymakes

thisandagain commented 5 years ago

/cc @fsih

kaaaaathy commented 5 years ago

^ Actually I was not able to repro this since last night. I'm not totally sure how consistent this is.