search

scratchfoundation / scratch-paint

Paint editor for Scratch 3.0
https://llk.github.io/scratch-paint/
BSD 3-Clause "New" or "Revised" License
175 stars 230 forks source link

Costume can get into crashing state #973

Open benjiwheeler opened 4 years ago

benjiwheeler commented 4 years ago

Expected Behavior

Paint editor does not crash

Actual Behavior

Paint editor does crash -- and resulting exported svg will reliably cause crash if uploaded

Steps to Reproduce

I was able to reproduce this identically on staging and production, on Windows Firefox:

  1. Be logged in
  2. Create a new project
  3. Reload the page
  4. Add a sprite; scroll and select Story-G
  5. Click on the Costumes tab
  6. Click on the green part of the G
  7. Drag the top handle slowly towards the bottom, until the selection is 0 pixels high
  8. It will disappear (seems to not happen every time)
  9. Click on Code tab, then back on Costumes tab
  10. Paint editor will crash

OR, just unzip and then upload this costume:

bad_svg.svg.zip

Operating System and Browser

Windows Firefox (seems to crash with any browser though, if you can get the disappearing to happen)

Bad svg content

It's not hard to see what might be malformed/bad about the svg's data:

<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="275.17" height="190.1576"><g transform="translate(18.17,21.1576)"><g data-paper-data="{&quot;isPaintingLayer&quot;:true}" fill="none" fill-rule="nonzero" stroke="none" stroke-width="1" stroke-linecap="butt" stroke-linejoin="miter" stroke-miterlimit="10" stroke-dasharray="" stroke-dashoffset="0" font-family="none" font-weight="none" font-size="none" text-anchor="none" style="mix-blend-mode: normal"><path d="MNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNz" data-paper-data="{&quot;origPos&quot;:null}" fill="#53ad4e"/><path d="M254.2,157.2c-0.7,-0.3 -1.1,-0.5 -1.8,-0.8c0.7,-0.1 1.1,-0.2 1.6,-0.4c0.1,0.4 0.2,0.7 0.2,1.2z" fill="#ffffff"/><path d="M257,166.1c-0.9,0.9 -1.7,2 -2.7,2.6c-0.7,0.4 -1.8,0.2 -2.7,0.3l-0.1,-0.2c0.7,-0.6 1.5,-1.2 2,-1.9c0.8,-1.2 1.9,-1.1 3.1,-0.9c0.1,-0.1 0.2,0 0.4,0.1z" fill="#ffffff"/><path d="M31.825,17.45c0,0.2 -0.1,0.5 -0.3,0.6c-1.1,1 -2.3,1.9 -3.5,3c-3.3,-6.5 -8.3,-8.5 -15.2,-6c1.5,-1.6 3.3,-2.6 5.4,-3.2c3.3,-1 6.5,-0.7 9.7,0.5c2.2,0.9 3.5,2.7 3.9,5.1z" data-paper-data="{&quot;origPos&quot;:null}" fill="#ffffff"/><path d="M3.7,-5.77487c0,3.1 -0.1,6.3 -0.2,9.4c0,1.3 -0.6,2.5 -1.8,3.1c-1,0.5 -2.1,0.9 -3.2,1.3c0,-0.1 -0.1,-0.2 -0.1,-0.2c0.4,-0.2 0.8,-0.4 1.2,-0.6c1.5,-0.8 2.2,-2 2.3,-3.7c0.2,-2 0.2,-3.9 -0.2,-5.9c-0.4,-1.7 -1.1,-2.2 -2.8,-2c-0.8,0.1 -1.7,0.2 -2.5,0.3c0,-0.1 -0.1,-0.1 -0.1,-0.2c1.3,-1.2 2.5,-2.4 3.9,-3.4c1.4,-1 3.5,0.3 3.5,1.9z" data-paper-data="{&quot;origPos&quot;:null}" fill="#ffffff"/><path d="M18.17,16.4424c-2,1.5 -3.9,3.1 -6.4,3.7c-2.4,0.7 -4.8,1.1 -7.3,1c-2.7,-0.2 -5.4,-0.7 -8,-1.7c-1.4,-0.6 -2.8,-1.2 -4.1,-2.1c-1.1,-0.7 -2.2,-1.6 -3,-2.6c-1.8,-2.3 -3.6,-4.7 -4.9,-7.4c-1.3,-2.9 -2,-5.9 -2.4,-9c-0.4,-2.7 -0.3,-5.4 0.3,-8c0.2,-0.9 0.5,-1.8 0.9,-2.6c1,-2.2 2.1,-4.2 3.6,-6c0.9,-1.1 2,-2 3.2,-2.9c-1.7,2.1 -2.8,4.4 -3.7,6.8c-0.5,1.7 -1,3.5 -1.1,5.2c-0.2,4.1 0.4,8.1 1.7,12c1.2,3.7 3.3,6.8 6.1,9.2c3.3,2.9 7.1,5.3 11.6,6.1c3.2,0.5 6.4,0.3 9.5,-0.5c1.4,-0.4 2.7,-0.8 4,-1.2z" data-paper-data="{&quot;origPos&quot;:null}" fill="#ffffff"/></g></g></svg>
fsih commented 4 years ago

I have a funny feeling it has to do with the part where it goes

<path d="MNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNzMNaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNcNaN,NaN NaN,NaN NaN,NaNz"

fsih commented 4 years ago

Related to https://github.com/LLK/scratch-paint/issues/977 ?