scriptorron / indi_pylibcamera

INDI libcamera driver made in Python
MIT License
11 stars 5 forks source link

missing gain config function for use with indi-allsky #13

Closed gmke closed 1 year ago

gmke commented 1 year ago

Mar 10 13:07:38 astroberry [ERROR] MainProcess allsky.unhandled_exception() #41: ' File "/home/pi/indi-allsky/indi_allsky/camera/indi.py", line 990, in getCcdGain\n raise Exception(\'Gain config not implemented for {0:s}, open an enhancement request\'.format(indi_exec))\n' Mar 10 13:07:38 astroberry [ERROR] MainProcess allsky.unhandled_exception() #41: ' File "/home/pi/indi-allsky/indi_allsky/camera/indi.py", line 548, in getCcdInfo\n gain_info = self.getCcdGain()\n' Mar 10 13:07:38 astroberry [ERROR] MainProcess allsky.unhandled_exception() #41: ' File "/home/pi/indi-allsky/indi_allsky/allsky.py", line 536, in _initialize\n ccd_info = self.indiclient.getCcdInfo()\n' Mar 10 13:07:38 astroberry [ERROR] MainProcess allsky.unhandled_exception() #41: ' File "/home/pi/indi-allsky/indi_allsky/allsky.py", line 884, in run\n self._initialize()\n' Mar 10 13:07:38 astroberry [ERROR] MainProcess allsky.unhandled_exception() #41: ' File "/home/pi/indi-allsky/allsky.py", line 119, in \n action_func(*args_list, **kwargs_dict)\n' Mar 10 13:07:38 astroberry [ERROR] MainProcess allsky.unhandled_exception() #36: Value: Gain config not implemented for ././indi_pylibcamera.py, open an enhancement request

scriptorron commented 1 year ago

Sorry, this is something that needs to be fixed in indi-allsky. I even do not know which version of indi-allsky you use. The Git project https://github.com/aaronwmorris/indi-allsky/blob/main/indi_allsky has a main and a dev branch and both do not use indi_pylibcamera. Furthermore in both the line 990 of indi.py can not raise such an exception.

What I have seen so far the indi-allsky needs value GAIN of property CCD_GAIN. The indi_pylibcamera driver provides this. Likely it is just not handled the right way in indi-allsky. Please open an issue in the indi-allsky project.

gmke commented 1 year ago

Thank you so much for your kind analysis. I will report it to Aaron. I use the main branch of indi-allsky and had to manually start the indiserver to convince indi-allsky to use the puli camera.

CS, Markus Am 10. März 2023, 16:30 +0100 schrieb scriptorron @.***>:

Sorry, this is something that needs to be fixed in indi-allsky. I even do not know which version of indi-allsky you use. The Git project https://github.com/aaronwmorris/indi-allsky/blob/main/indi_allsky has a main and a dev branch and both do not use indi_pylibcamera. Furthermore in both the line 990 of indi.py can not raise such an exception. What I have seen so far the indi-allsky needs value GAIN of property CCD_GAIN. The indi_pylibcamera driver provides this. Likely it is just not handled the right way in indi-allsky. Please open an issue in the indi-allsky project. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

aaronwmorris commented 1 year ago

I have added support for indi_pylibcamera.py

https://github.com/aaronwmorris/indi-allsky/pull/630

scriptorron commented 1 year ago

Aaron, thank you very much. If all agree I would like to close this issue.