search

scriptorron / indi_pylibcamera

INDI libcamera driver made in Python
MIT License
11 stars 5 forks source link

install.sh updates #28

Closed aaronwmorris closed 1 year ago

aaronwmorris commented 1 year ago

I submitted PR #27 with some fixes and updates for install.sh

My update does not require any user input as to the location of the server script. It is automatically detected.

Also, required system python packages are installed.

There was another issue if you have a custom install of indi in /usr/local/bin, the location of the XML file needs to be updated. That is included, as well.

scriptorron commented 1 year ago

Aaron,

Thank you very much! I will merge it.

I am wondering why you used tee instead of catin this code line:

sudo tee "${INDI_SERVER_USR}/share/indi/indi_pylibcamera.xml" >/dev/null <<EOL

It is good as it is. I just ask to learn :-)

Regards, Ronald

aaronwmorris commented 1 year ago

In this case, it could probably be changed to cat. I got into the habit of using tee to write to files with sudo, but with the multiline input, it does not matter.

This is what I mean:

echo "foobar" | sudo tee /path/to/file
scriptorron commented 1 year ago

Thank you. I feared that there is some security issue with cat.

No need to change your script. I merged it already.

Thank you again for your contribution.

scriptorron commented 1 year ago

PR #27 is merged.