Closed Lilly-May closed 3 months ago
Attention: Patch coverage is 57.14286%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 63.48%. Comparing base (
80ef0f0
) to head (2888906
). Report is 3 commits behind head on main.:exclamation: Current head 2888906 differs from pull request most recent head 8faad36. Consider uploading reports for the commit 8faad36 to get more accurate results
We might want to wait for a fix for issue #566 before merging this (or rather include the fix in this PR), even though the issue is not directly related to this PR. It persists even when using the three separate methods (load
, train
, get_embeddings
).
Yup! I'll try n check it out ASAP!
PR Checklist
docs
is updatedDescription of changes
Replaced three separate methods (
load
,train
, andget_embeddings
) in theMLPClassifierSpace
with a singlecompute
method. The motivation for this is to unify the API, aligning it with other perturbation space methods, which all feature acompute
method.The
load
,train
, andget_embeddings
methods persist, however, they now trigger aDeprecationWarning
when called that points users to the newcompute
method.