Closed Lilly-May closed 2 weeks ago
@Lilly-May can you change this so that we use string literals for the dataset names? Maybe Literal["gdsc_1", "gdsc_2"]
or something of that sort? Then we can merge it
Sure! But you still want it to work with integers as well, right? So something like Literal["gdsc_1", "gdsc_2"] | Literal[1, 2]
?
I'd drop support for integers
Description of changes
1
or2
and otherwise throw an error.annotate_from_gdsc
method, which now uses the correct GDSC data to compute. Previously, the code would fail for me if GDSC2 was used.Statsmodel
example. I believe an old class name might have been used here. It's still not a working example as theadata
is not defined, but I think it is much easier for users to understand now.