scverse / pertpy

Perturbation Analysis in the scverse ecosystem.
https://pertpy.readthedocs.io/en/latest/
MIT License
92 stars 19 forks source link

Metadata GDSC annotation improvements #625

Closed Lilly-May closed 2 weeks ago

Lilly-May commented 3 weeks ago

Description of changes

Zethson commented 2 weeks ago

@Lilly-May can you change this so that we use string literals for the dataset names? Maybe Literal["gdsc_1", "gdsc_2"] or something of that sort? Then we can merge it

Lilly-May commented 2 weeks ago

Sure! But you still want it to work with integers as well, right? So something like Literal["gdsc_1", "gdsc_2"] | Literal[1, 2]?

Zethson commented 2 weeks ago

I'd drop support for integers