search

scyllagroup / UmbracoFlare

This project aims to provide a basic level of service integration between Cloudflare and the open-source ASP.NET CMS Umbraco.
https://www.umbracoflare.com/
Creative Commons Attribution Share Alike 4.0 International
18 stars 3 forks source link

Update CloudflareApiController.cs #11

Closed cyberknet closed 6 years ago

cyberknet commented 6 years ago

Update CloudflareApiController to force TLS 1.2 now that CloudFlare requires it

jmcaveney commented 6 years ago

This is already in the new version of this package. https://github.com/scyllagroup/UmbracoFlare/blob/master/UmbracoFlare/App_Start/Startup.cs

cyberknet commented 6 years ago

I see. It still wasn't working with a clone from yesterday, so I looked at bit more. Startup.cs is not added to UmbracoFlare project. I do agree it is a better place to add it, so perhaps the better pull request would be to include Startup.cs into the UmbracoFlare project? Thanks for the polite pointer.

jmcaveney commented 6 years ago

oh man, that's our fault. I'll fix that right away.

cyberknet commented 6 years ago

Thanks for the feedback, great pull request experience. I'll keep an eye on the project - hope to contribute in the future. Closing this PR for now since there is nothing to do - the original change is far better.

jmcaveney commented 6 years ago

thanks for the feedback, and the assist. we're pushing a new version to nuget immediately to fix that issue. we haven't updated our.umbraco just yet, but should be in the next few days.