search

scyllagroup / UmbracoFlare

This project aims to provide a basic level of service integration between Cloudflare and the open-source ASP.NET CMS Umbraco.
https://www.umbracoflare.com/
Creative Commons Attribution Share Alike 4.0 International
18 stars 3 forks source link

Automate Stylesheet and Script Purges #13

Closed cyberknet closed 5 years ago

cyberknet commented 5 years ago

Added support for UmbracoFlare to automatically purge scripts and stylesheets when they are edited through the backend - resolves Issue #12

cyberknet commented 5 years ago

Any thoughts on this PR? I've been running it these past two days on my site and it's been working perfectly.

cyberknet commented 5 years ago

Just checking in - have you had a chance to review this pull request yet? It was a pretty small change. It is still working fine on my site. I can maintain a patch if I need to, but I'd much prefer to have the change integrated upstream :)

markadrake commented 5 years ago

Hey @cyberknet - just saw this. I will review with the team on Tuesday and will make either (a) feedback or (b) merging this a priority! We have a number of sites using UmbracoFlare so it would be good to try it across a few different installations just to make sure. Thanks for your contribution!

cyberknet commented 5 years ago

Thanks so much - let me know if you end up with feedback and I will make any necessary changes.

cyberknet commented 5 years ago

@markadrake @jmcaveney Were you able to review this with the team last Tuesday? If not, on the agenda for tomorrow?

cyberknet commented 5 years ago

@markadrake @jmcaveney Not sure what the usual integration schedule is like, but it's been a month here and honestly no meaningful feedback yet. The patch isn't overly large, and the functionality is pretty small. I do believe the intent is good... so I was wondering if can you give me some insight on what the hold up is please?

jmcaveney commented 5 years ago

sorry for the long delay here, had some family issues in October to take care of and have been playing catchup since. thank you for the pull request, looks good.

cyberknet commented 5 years ago

Thanks for merging this. I know it can be hectic trying to balance OSS projects and pay-the-bills activities. I appreciate your time.