sd805
commented
1 year ago Thank you! Pull requests are definitely welcome.
Closed elvissteinjr closed 1 year ago
sd805
commented
1 year ago Thank you! Pull requests are definitely welcome.
Various improvements to action manifest and default bindings
Add skeleton action SteamVR was logging errors about the skeleton being bound in default bindings but the action not existing. As far as I can tell, skeletal data isn't used by the mod (yet?) so an alternative to this would be remove the action from the bindings instead.
Mark actions not bound by default as optional With the removal of the unbound actions as mentioned below, the binding UI will point out the Spray and Show Scoreboard actions as suggested to be bound. This is subjective, but I feel like they're not essential and are fine to be marked as optional.
Hide base action set in binding UI There are no user bindable actions in this set, so hiding it seems like a good option.
Add localization strings for actions Unlocalized names are stripped of their captilization in the binding UI. This adds them back and puts some spaces where appropriate.
Remove unbound actions without device path from default bindings. This confuses SteamVR and breaks the binding UI when trying to create chords. The main reason I started poking things here. Unbound actions should not be present in the default binding files. SteamVR logs errors for this and it wouldn't matter much of course... but it breaks the binding UI for the SteamVR session when attempting to create chords, so that's not great.
No idea how open to pull requests you are, but I was thinking looking into overlay parts of the code as well, as I have some experience there. Seeing some potential improvements. Can't be much help with the actual modding of the game though.