sdmisra / AvianAnthems

This is an app that enables access to the beautiful music of the world around us
https://avian-anthems.vercel.app
2 stars 3 forks source link

Feat/search results view #19

Closed sdmisra closed 1 year ago

sdmisra commented 1 year ago

🛠️ Description of this branch

🧠 Context or Rationale for this code

What is helpful for team to know and understand about decisions made in this code.

This is a big sign that we are getting more comfortable with TypeScript - it is very specific about how to pass data around. We've decided to stick with class based components for the time being - it is interesting to see how typescript interacts with prop drilling.

👀 Checks

✍🏽 Notes, Questions, What's Next

I'll update the project board after merge.

Screenshot

jmartin777 commented 1 year ago

It's great to see that we're getting more comfortable with TypeScript and leveraging its benefits. I understand the decision to stick with class-based components for now, and it's interesting to see how TypeScript interacts with prop drilling in this context. I reviewed the changes you made and everything looks good to me. I especially like how you rewired the fetch method to use state in the Form component rather than the App component, which improves the code organization. I also noticed that you found the proper syntax for typing methods from the App component, which is a great addition. It helps ensure type safety and improves the maintainability of our codebase. Overall, I'm impressed with team work here.