search

sdsc-hpc-training-org / reverse-proxy

1 stars 5 forks source link

Change runtime dir and use nbserver.json to get port #1

Closed mulroony closed 4 years ago

mulroony commented 4 years ago

Great project, really useful. I noticed the method for getting the port number might be prone to parsing issues. The PR puts all the run configuration into a temporary directory, which includes a 'nbserver-XXXX.json' that contains the port (and other) configuration information. I did not update the other two notebook batch scripts, just the main one.

I also took a page from various workflow managers and put everything into a common temp folder and changed the naming convention a bit.

JamesMcDougallJr commented 4 years ago

I agree this is the approach we should take. I just implemented almost the same thing in a slightly different way, thank you for your suggestion! This will be integrated into all future batch scripts.

marypthomas commented 4 years ago

james —

sdsc-hpc-training-org/reverse-proxy reply@reply.github.com

just wondering — do we have an email address for each repo because we have an organization or do all repos have this feature?

On May 28, 2020, at 9:27 PM, james-mcdougall notifications@github.com wrote:

I agree this is the approach we should take. I just implemented almost the same thing in a slightly different way, thank you for your suggestion! This will be integrated into all future batch scripts.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sdsc-hpc-training-org/reverse-proxy/pull/1#issuecomment-635751133, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMDVOGZ7B24STFHOLVVD7TRT42ULANCNFSM4NIAS4IQ.

mulroony commented 4 years ago

Cool. Thanks again for the useful utility.