seamapi / public-tracker

0 stars 0 forks source link

RBoy-conflict on Smartthings should throw a specific error/warning for internationalization #3

Open seveibar opened 1 year ago

seveibar commented 1 year ago

Prerequisites

Description

The message: "We detected the use of RBoy Apps to manage this device, which may conflict with Seam's ability to set codes on the device. We recommend disabling RBoy Apps for devices that will be managed using Seam." should have a specific error/warning enum or metadata for internationalization.

seveibar commented 1 year ago

@ethanplee14 I would recommend the third_party_integration_detected warning rather than a specific RBoy error/warning (we can add metadata allowing customers to customize the message)

ethanplee14 commented 1 year ago

AFAIK Rboy is smartthings specific so I was thinking of having a specific error like smartthings_rboy_integration_detected for it @seveibar. You still think generic is better with a specific message?

seveibar commented 1 year ago

AFAIK Rboy is smartthings specific so I was thinking of having a specific error like smartthings_rboy_integration_detected for it @seveibar. You still think generic is better with a specific message?

Yea we aren't trying to create specific errors for everything, rather we're trying to make it as easy as possible to implement control flow for customers, in this case third_party_integration_detected could just specify the conflicting_integrations: ["rboy"], which could then be used as part of the internationalization.