Emit events when converting managed and unmanaged devices

seamapi / public-tracker

0 stars 0 forks source link

Emit events when converting managed and unmanaged devices #6

Closed seveibar closed 1 year ago

seveibar commented 1 year ago

Prerequisites

Can this issue be reproduced in a sandbox workspace? Yes
Does this issue represent a regression? Did it previously work? No

Description

device.connected should be emitted after managing a device.

Steps to Reproduce

Unmanage a sandbox device ("Deactivate Device" in console)
Re-manage the sandbox device
Device does not have a new device.connected event

ethanplee14 commented 1 year ago

Do we want to emit device.connected or do we want to keep the same behavior of access codes and do device.unmanaged.converted_to_managed

razor-x commented 1 year ago

I agree we should NOT emit device.connected and follow the same conventions as access codes with the device.unmanaged.converted_to_managed and device.converted_to_unmanaged.

razor-x commented 1 year ago

New events documented in this PR: https://github.com/seamapi/api-docs/pull/122 and live at https://docs.seam.co/latest/api-clients/events#event-types

See device.converted_to_unmanaged and device.unmanaged.converted_to_managed.