seamapi / public-tracker

0 stars 0 forks source link

Access code updates aren't applied when `access_code.was_modified_externally` is true #86

Closed panzerchris closed 7 months ago

panzerchris commented 8 months ago

Prerequisites

Description

When an access code is updated externally we set access_code.was_modified_externally to true. If a further change is made to that access code on Seam (e.g. to the start time), we do not sync the changes to the device.

Steps to Reproduce

  1. Create an access code on a device and wait until it has synced successfully
  2. Modify the access code externally (e.g. change the times)
  3. Update the access code on Seam (e.g. change the times)

Expected behavior: [What you expected to happen]

The final update should be synced to the device and take precedence over the external modification.

Actual behavior: [What actually happened]

The change to the access code time is not synced to the device. As a by product we can also report the code as unset/unseen on the device. It's still present but without-dated information.

Versions

Additional Information

Any additional information, screenshots or code you think might be necessary to reproduce the issue.

Discussion here: https://hello-seam.slack.com/archives/C0586B3NSPL/p1706536987510959 Potentially related issue here https://github.com/seamapi/public-tracker/issues/81

panzerchris commented 7 months ago

Some fixes went in recently that should have resolved this