search

seaweedfs / seaweedfs-operator

seaweedfs kubernetes operator
Apache License 2.0
174 stars 42 forks source link

Investigate why the Helm Chart Release GitHub Action didn't work #97

Open jessebot opened 11 months ago

jessebot commented 11 months ago

We need to investigate why the release didn't show up here: https://github.com/seaweedfs/seaweedfs-operator/releases

Here's the GitHub Workflow: https://github.com/seaweedfs/seaweedfs-operator/blob/master/.github/workflows/helm_chart_release.yml

Here's the job where it ran: https://github.com/seaweedfs/seaweedfs-operator/actions/runs/6921460451/job/18827076156

I will test this on a fork and see what I can surmise. My first inclination is that the perhaps it has to do with one of the following:

There's also a chance it has to do with the directory the helm chart is in. It's normally expected that the helm chart is in charts/appname so in this case it'd be charts/seaweedfs-operator, but I don't think that's it though, because I set the chart dir in the workflow according to the docs :thinking:

https://github.com/seaweedfs/seaweedfs-operator/blob/8b699939f2f8c1925114367fa690d560b2dfc10e/.github/workflows/helm_chart_release.yml#L40-L41

jessebot commented 11 months ago

@chrislusf could you please create the gh-pages branch, when you have a chance? I think this is why the helm chart release did not work. Thank you for all your help 🙏

chrislusf commented 11 months ago

Created https://github.com/seaweedfs/seaweedfs-operator/tree/gh-pages

Let me know if anything is needed.

xavier83 commented 1 month ago

can't we take inspiration from seaweedfs for this?

Created PR https://github.com/seaweedfs/seaweedfs-operator/pull/115 for testing this.

xavier83 commented 3 weeks ago

@chrislusf #116 seems to publish the charts now.

The following works.

helm repo add seaweedfs-operator https://seaweedfs.github.io/seaweedfs-operator/helm
helm template  seaweedfs-operator seaweedfs-operator/seaweedfs-operator

we may have to clean-up gh-pages branch similar to https://github.com/seaweedfs/seaweedfs/tree/gh-pages/ https://#117