sebbaum / generator-laravel-5

Scaffold Laravel 5.7 applications with ease.
Other
18 stars 0 forks source link

Modifications & Pull Request #18

Open eaverdeja opened 5 years ago

eaverdeja commented 5 years ago

Hello Sebastian!

First of all, thanks for the repo, this was a really nice find :)

I cloned the repo and made several modifications:

Obviously I don't mind on maintaining my own fork, but I would to like to know if you're interested in pull requests!

Thanks again and cheers from Brazil

eaverdeja commented 5 years ago

I forgot to mention I'm doing all of this on a docker setup (the generator is called from inside a php container). I don't know if you use Docker or if it's interesting to you, but it makes my workflow quite easier. With the generator + docker containers for PHP, nginx and mysql I can get from zero to a working , configured and customized laravel app in under 1 hour.

For example, the PHP container uses hirak/prestissimo for faster composer installs and updates. On my beatup machine, the whole generator takes about 6 minutes when installing all of the dev packages + ~10 other packages.

Maybe this isn't the scope for this project, but if it interested you, I'll gladly include the docker files in the pull request!

sebbaum commented 5 years ago

Hi, @eaverdeja

thanks for your message.

Generally, I am interested in pull requests. Your modifications sound promising.

I am not into TypeScript at the moment and prefer JS. However, TypeScript is possible.

Concerning Docker. I am interested in Docker as well. Maybe you can put your Docker setup in a separate pull request. Smaller pull requests are easier to handle. ;-)

Greatings from Germany