search

segment-any-text / wtpsplit

Toolkit to segment text into sentences or other semantic units in a robust, efficient and adaptable way.
MIT License
677 stars 39 forks source link

Python bindings frequently segfault #3

Closed bminixhofer closed 4 years ago

bminixhofer commented 4 years ago

Python bindings frequently cause a segfault. This has apparently been resolved by https://github.com/PyO3/pyo3/commit/7b1e8a6daff70bffd7bf7b5b7297fd257ecde2e2 which is not yet released.

Current solution: Depend on a pyo3@master:

pyo3 = {git = "https://github.com/PyO3/pyo3", rev = "e6f8fa7"}

and a rust-numpy fork which uses the same rev:

numpy = {git = "https://github.com/bminixhofer/rust-numpy"}

in bindings/python/Cargo.toml.

This should be changed as soon as PyO3 0.10.x is released.

bminixhofer commented 4 years ago

Fixed by 8b759282ddd599584713aa1b936e00c7c1cbb257.