search

seiyable / vue-simple-svg

A simple Vue.js plugin that allows you to load a SVG image as an inline SVG with an access to change its fill colors
MIT License
80 stars 23 forks source link

Add new props: tag, wrapperClasses, svgClasses #15

Open webistomin opened 5 years ago

webistomin commented 5 years ago

Hi! Thanks for your plugin.

During the development I had a problem. I needed to put the svg inside the <button>, but the plugin automatically added a div wrapper. I think this is not quite semantic. <button> must contain only phrasing content. Phrasing content is defined as including <span> or something else but not <div>.

So, I added new props for tag name. Also added props for wrapper and svg element classes to add more flexibility and functionality to plugin.

shrpne commented 5 years ago

@webistomin you can check vue-inline-svg it doesn't add wrapper at all.

zincplusplus commented 5 years ago

I was just about to code this. Thanks @webistomin ! What is holding back this MR @seiyable ?