search

selfrefactor / rambdax

Extended version of Rambda
https://selfrefactor.github.io/rambdax
MIT License
221 stars 26 forks source link

fix: error TS2314: Generic type 'MapInterface<T>' #28

Closed darosh closed 5 years ago

darosh commented 5 years ago

Fixing typings error:

PS C:\_GITHUB\rambdax> npx typescript .\index.d.ts
npx: installed 1 in 3.636s
index.d.ts:633:45 - error TS2314: Generic type 'MapInterface<T>' requires 1 type argument(s).

633     map<In, Out>(fn: MapFunction<In, Out>): MapInterface<In, Out>
                                                ~~~~~~~~~~~~~~~~~~~~~

Found 1 error.
selfrefactor commented 5 years ago

Thank you for catching that

Xs-and-10s commented 5 years ago

@selfrefactor I see this change in master, but not in the published rambdax@2.8.1 - would you mind publishing a new version that has this change?

selfrefactor commented 5 years ago

sure, I will do that later today

selfrefactor commented 5 years ago

2.8.2 should have it. Let me know if that is not the case.

Xs-and-10s commented 5 years ago

@selfrefactor not seeing 2.8.2 here: https://www.npmjs.com/package/rambdax - do you know how long it takes for npm to pick up the new version?

selfrefactor commented 5 years ago

Weird.

As you can see at https://unpkg.com/rambdax@2.8.3/dist/rambdax.js version is indeed live but npm site keeps info for 2.8.0

I can try with a minor bump

selfrefactor commented 5 years ago

Still no result. I would wait a bit more and will open npm issue

selfrefactor commented 5 years ago

ok, so the version is live but it stays with the old one at https://www.npmjs.com/package/rambdax which is npm issue not ours

Xs-and-10s commented 5 years ago

was able to download 2.9.0 successfully - thanks for the amazing turnaround!