Closed firede closed 4 years ago
Thank you for the PR. I will use it as a base to fix the problem, as I have a pipeline that creates the local copy of ts-toolbelt
. Approving the PR might fix the issue for this version, but it will be overwritten on the next bump.
Could you share your tsconfig.json
file as I am curious which option cause this bug?
{
"compilerOptions": {
"target": "es5",
"lib": ["dom", "dom.iterable", "esnext"],
"baseUrl": ".",
"allowJs": true,
"skipLibCheck": true,
"strict": false,
"forceConsistentCasingInFileNames": true,
"noEmit": true,
"esModuleInterop": true,
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve"
},
"exclude": ["node_modules"],
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"]
}
I think, isolatedModules: true
will cause this bug.
Yes, indeed isolatedModules: true
is the cultpit. The issue is also reported in Rambda
repo. I will apply the fix during the weekend.
A fix is applied to Rambda
and will be published tomorrow.
As for Rambdax
- I was in the middle of adding new methods, so the fix will come after a few days.
@firede I applied your changes to the whole ts-toolbelt
pipeline and I made 4.2.0
release. Thanks again for your PR as it provided clear solution to important issue.
Let me know if you are still facing this issue with the latest Rambdax
version.
I am closing this PR as the changes are applied. Please comment if the issue is still present.
When I upgrade rambdax to 4.0, I got this:
So I created the PR to fix it, thanks.