search

selfrefactor / rambdax

Extended version of Rambda
https://selfrefactor.github.io/rambdax
MIT License
221 stars 26 forks source link

removeIndex has backward arguments #66

Closed whitelizard closed 3 years ago

whitelizard commented 3 years ago

removeIndex seems to take a switched (wrong) order of the 2 arguments. And the tests seem to be wrong as well.

It should be removeIndex(index, list)

but it is removeIndex(list, index)

making it bad for composition.

selfrefactor commented 3 years ago

Thanks for filing this problem. I'll check it and get back to you.

selfrefactor commented 3 years ago

You are very correct. Typings are correct, but indeed the logic was wrong. The fix is already applied, but it will go live with the next release. I'll keep the issue open, so I can inform you once the new release is published.

selfrefactor commented 3 years ago

It should be released with 7.3.0. Let me know if the problem persist.