semuconsulting / PyGPSClient

Python Graphical GPS Client Application supporting NMEA, UBX, RTCM3, NTRIP & SPARTN Protocols
BSD 3-Clause "New" or "Revised" License
493 stars 98 forks source link

I'm getting a KeyError: 'serial_settings' from stream_handler.py when trying to use a socket as gnss source. Approx line 124 but I may have added some debug prints. #119

Closed semuadmin closed 6 months ago

semuadmin commented 6 months ago

I'm getting a KeyError: 'serial_settings' from stream_handler.py when trying to use a socket as gnss source. Approx line 124 but I may have added some debug prints.

The problem seems to be that the access of settings["serial_settings"] has been moved from within the CONNECTED-specific code up a few lines. I'm guessing that when conntype is CONNECTED_SOCKET, settings doesn't have any "serial_settings".

Looks like it happened in 42e2ae0 "Merge branch 'ubx_simulation' into RC-1.4.10 "

Originally posted by @divenal in https://github.com/semuconsulting/PyGPSClient/discussions/118